We are going to update to Godot 4.6 as it looks like it has no bugs that impact us (we had to skip 4.5.1 due to input mapping problems).
One significant change is that now on mouse click any GUI element does not display the focus style anymore, only if doing keyboard navigation. I think that may lead to a few slightly more confusing GUI behaviours than before so I opened an issue about checking them:
opened 12:25PM - 29 Jan 26 UTC
programming
review
gui
C#
It looks like our focus grabbers default to making the focus visible, which I th… ink is fine, but now clicking an element makes the focus disappear and for example pressing space still activates the last pressed button even when not highlighted which may be slightly confusing for example when using the cheats panel (and we might want to add something like clicking the main game screen {so no node at all} to deselect all GUI focus)
Info n the new focus stuff: https://github.com/godotengine/godot/pull/110250
Here’s my PR that I plan to merge tomorrow:
master ← godot_4.6
opened 01:28PM - 29 Jan 26 UTC
**Brief Description of What This PR Does**
As I did not find any new bugs and t… he problem with 4.5.1 was fixed it looks like we can finally update the used engine version
**Related Issues**
**Progress Checklist**
Note: before starting this checklist the PR should be marked as non-draft.
- [x] PR author has checked that this PR works as intended and doesn't
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
- [ ] Initial code review passed (this and further items should not be checked by the PR author)
- [ ] Functionality is confirmed working by another person (see above checklist link)
- [ ] Final code review is passed and code conforms to the
[styleguide](https://github.com/Revolutionary-Games/Thrive/blob/master/doc/style_guide.md).
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
[styleguide](https://github.com/Revolutionary-Games/Thrive/blob/master/doc/style_guide.md#git).
2 Likes